Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newlines from dependencies to fix Python sdist #10473

Closed
wants to merge 1 commit into from

Conversation

xhochy
Copy link
Contributor

@xhochy xhochy commented Aug 14, 2023

Fixes #10366

@stinodego
Copy link
Member

stinodego commented Aug 14, 2023

Thanks for the patch - but how does this fix the issue? How have you verified this?

Sounds to me like this is a bug in maturin that should be reported there (although we can accept a temporary patch of course).

@xhochy
Copy link
Contributor Author

xhochy commented Aug 14, 2023

Yes, sadly this fixes it. I have verified this using maturin sdist -m py-polars/Cargo.toml and then pip installing the resulting sdist.

@xhochy
Copy link
Contributor Author

xhochy commented Aug 14, 2023

I can make an issue with maturin in the coming days.

@ritchie46
Copy link
Member

I shall open an issue, pointing to this fix.

@ritchie46
Copy link
Member

See: PyO3/maturin#1732

@messense
Copy link
Contributor

See also toml-rs/toml#594

@xhochy
Copy link
Contributor Author

xhochy commented Aug 14, 2023

I'm happy to fix the lint issues and the merge conflicts if there is interest in merging this.

@stinodego
Copy link
Member

stinodego commented Aug 14, 2023

I think @messense just released a patch version of maturin that should solve the issue - I'll set our minimum version to 1.2.1. So this PR can be closed.

Thanks @xhochy for your help in finding this issue!

@stinodego stinodego closed this Aug 14, 2023
@xhochy xhochy deleted the fix-sdist branch August 14, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sdist broken for 0.18.12 and 0.18.13
4 participants