fix: Proper equality for easy::Value #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`LinkedHashMap`s equality checked order when we don't want it to. It also isn't maintained. So we're switching to `IndexMap` Unfortunately, there are other ordering issues in the relevant test that makes it hard to get right, so went ahead and removed it. Unfortunately, I didn't see any change in performance. Fixes toml-rs#194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinkedHashMaps equality checked order when we don't want it to. Italso isn't maintained. So we're switching to
IndexMapUnfortunately, there are other ordering issues in the relevant test that
makes it hard to get right, so went ahead and removed it.
Unfortunately, I didn't see any change in performance.
Fixes #194