Apply feedkback from porting cargo #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us more implementation flexibility BREAKING CHANGE: Instead of dealing with `Document::root`, use `Document::as_table()` or `Document::as_table_mut()`.
In porting cargo to toml_edit, I found it would be nice if we allowed the document to be used as the table it wraps.
This trait isn't normally interacted with by users
This is being pulled over from the `easy` API. Found this would be useful inside of cargo. Some direct document interation is needed before using serde to convert it to native types.
epage
added a commit
to epage/toml_edit
that referenced
this pull request
Jan 12, 2022
In some cases, this makes recursive algorithms easier. This is a spiritual revert of part of toml-rs#240.
epage
added a commit
that referenced
this pull request
Jan 12, 2022
In some cases, this makes recursive algorithms easier. This is a spiritual revert of part of #240.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started an experiment in porting cargo to
toml_editand found some small API changes would be beneficial.