fix!: Allow people iterating to modify the key #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more consistent with the other `fmt`s.
By providing a `KeyMut`, we can safely allow people to modify keys while iterating. We've extending the interface to allow greater interop to reduce pain for people who don't need this. BREAKING CHANGE: `IterMut`s for table-likes now use a `KeyMut` key instead of `&str`.
sunshowers
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Ah yeah, I think this should solve the practical issue in #261. Thanks!
I can put an update up after you land this :)
|
Done! |
ordian
reviewed
Nov 23, 2021
| } | ||
|
|
||
| /// Returns the surrounding whitespace | ||
| pub fn decor_mut(&mut self) -> &mut Decor { |
There was a problem hiding this comment.
this will allow for more "shoot yourself in the foot" cases, e.g. adding "# comment" to the decor
There was a problem hiding this comment.
That is true with all of the decor_mut functions we already expose. Created #267 to track this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By providing a
KeyMut, we can safely allow people to modify keys whileiterating. We've extending the interface to allow greater interop to
reduce pain for people who don't need this.
BREAKING CHANGE:
IterMuts for table-likes now use aKeyMutkeyinstead of
&str.