Skip to content

Commit

Permalink
Add support for NDK crashlytics on Android. Resolves dpa99c#17.
Browse files Browse the repository at this point in the history
  • Loading branch information
dpa99c authored and tom-hartz committed Nov 22, 2019
1 parent 57fa531 commit 751f0c9
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ The following plugin variables are use to specify the follow Gradle dependency v
- `ANDROID_FIREBASE_PERF_VERSION` => `com.google.firebase:firebase-perf`
- `ANDROID_FIREBASE_AUTH_VERSION` => `com.google.firebase:firebase-auth`
- `ANDROID_CRASHLYTICS_VERSION` => `com.crashlytics.sdk.android:crashlytics`
- `ANDROID_CRASHLYTICS_NDK_VERSION` => `com.crashlytics.sdk.android:crashlytics-ndk`
- `ANDROID_SHORTCUTBADGER_VERSION` => `me.leolin:ShortcutBadger`

The following plugin variables are use to specify the follow Cocoapods dependency versions on iOS:
Expand All @@ -105,7 +106,8 @@ For example, to explicitly specify all the component versions at plugin install
--variable ANDROID_FIREBASE_CONFIG_VERSION=18.0.0 \
--variable ANDROID_FIREBASE_PERF_VERSION=18.0.0 \
--variable ANDROID_FIREBASE_AUTH_VERSION=18.0.0 \
--variable ANDROID_CRASHLYTICS_VERSION=2.9.8 \
--variable ANDROID_CRASHLYTICS_VERSION=2.10.1 \
--variable ANDROID_CRASHLYTICS_NDK_VERSION=2.1.0 \
--variable ANDROID_SHORTCUTBADGER_VERSION=1.1.22 \
--variable IOS_FIREBASE_CORE_VERSION=5.20.2 \
--variable IOS_FIREBASE_AUTH_VERSION=5.20.2 \
Expand Down
4 changes: 3 additions & 1 deletion plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@
<preference name="ANDROID_FIREBASE_CONFIG_VERSION" default="18.0.0" />
<preference name="ANDROID_FIREBASE_PERF_VERSION" default="18.0.0" />
<preference name="ANDROID_FIREBASE_AUTH_VERSION" default="18.0.0" />
<preference name="ANDROID_CRASHLYTICS_VERSION" default="2.9.8" />
<preference name="ANDROID_CRASHLYTICS_VERSION" default="2.10.1" />
<preference name="ANDROID_CRASHLYTICS_NDK_VERSION" default="2.1.0" />
<preference name="ANDROID_SHORTCUTBADGER_VERSION" default="1.1.22" />

<framework src="com.google.android.gms:play-services-tagmanager:$ANDROID_PLAY_SERVICES_TAGMANAGER_VERSION" />
Expand All @@ -70,6 +71,7 @@
<framework src="com.google.firebase:firebase-perf:$ANDROID_FIREBASE_PERF_VERSION" />
<framework src="com.google.firebase:firebase-auth:$ANDROID_FIREBASE_AUTH_VERSION" />
<framework src="com.crashlytics.sdk.android:crashlytics:$ANDROID_CRASHLYTICS_VERSION" />
<framework src="com.crashlytics.sdk.android:crashlytics-ndk:$ANDROID_CRASHLYTICS_NDK_VERSION" />
<framework src="me.leolin:ShortcutBadger:$ANDROID_SHORTCUTBADGER_VERSION" />

</platform>
Expand Down
5 changes: 5 additions & 0 deletions src/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,9 @@ repositories {
cdvPluginPostBuildExtras.add({
apply plugin: 'com.google.gms.google-services'
apply plugin: 'io.fabric'

// Enable Crashlytics NDK reporting
crashlytics {
enableNdk true
}
})

0 comments on commit 751f0c9

Please sign in to comment.