Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constants typecasted trigger magic number. #13

Closed
dtracers opened this issue Sep 20, 2020 · 2 comments
Closed

Constants typecasted trigger magic number. #13

dtracers opened this issue Sep 20, 2020 · 2 comments
Assignees
@tommy-muehle
Labels
bug Something isn't working

Comments

@dtracers
Copy link

const MyConstantValue = float32(20)

This will trigger the check when it is being used as a constant and not as a magic number
@tommy-muehle tommy-muehle added the bug Something isn't working label Sep 23, 2020
@tommy-muehle tommy-muehle self-assigned this Sep 23, 2020
@tommy-muehle
Copy link
Owner

@dtracers Thanks for the report!

tommy-muehle added a commit that referenced this issue Sep 23, 2020
@tommy-muehle
Check constant definitions first, fixes #13
32e1020
@tommy-muehle
Copy link
Owner

@dtracers Thanks again for your report. I fixed the bug with version 2.0.2. Feel free to try it out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tommy-muehle tommy-muehle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tommy-muehle @dtracers