Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for date-filter. Example included #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changes for date-filter. Example included #12

wants to merge 1 commit into from

Conversation

manojsethi
Copy link

Hello Tommy,

Please review the date filter. I have added a demo as well.

Maybe you can do some good jQuery stuff than me. Hope it helps.

Cheers
Manoj

@tommyp
Copy link
Owner

tommyp commented Sep 14, 2016

While I agree with the change in principle, I'm not going to merge as is. A lot of the diff is whitespace changes which are unnecessary and it feels like this code could be improved. I may end up refactoring the switch to be a case statement for the input which feels like a better way to approach this problem. Feel free to keep using your fork but if I do end up refactoring it and adding a date filter I'll be sure to mention your name in the commit.

@manojsethi
Copy link
Author

Thanks, looking forward to improved version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants