solution m3-025 #179
Open
solution m3-025 #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effedib
reviewed
Jan 13, 2025
| if c == 0: | ||
| is_win = True | ||
| else: | ||
| is_win = False |
effedib
reviewed
Jan 13, 2025
| is_win = True | ||
| else: | ||
| is_win = False | ||
| break |
effedib
reviewed
Jan 13, 2025
| is_win = False | ||
| # check columns | ||
| for n_column in dict_card.values(): | ||
| if is_win: |
effedib
reviewed
Jan 13, 2025
| else: | ||
| for c in n_column: | ||
| if c == 0: | ||
| is_win = True |
There was a problem hiding this comment.
if is_win == true, why you don't break the loop? Moreover, c is a number not a column if I understood correctly, so a single 0 is not enought, right?
effedib
reviewed
Jan 13, 2025
| break | ||
| # check diagonals | ||
| if not is_win: | ||
| diagonal_1 = dict_card['B'][0], dict_card['I'][1], dict_card['N'][2], dict_card['G'][3], dict_card['O'][4] |
effedib
reviewed
Jan 13, 2025
| break | ||
| return is_win | ||
|
|
||
| card_1 = { |
There was a problem hiding this comment.
try to generate the cards randomly using the random library?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.