-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading a custom TLS server name from kubeconfig
#270
Conversation
kubeconfig
5cb1fc7
to
0eeed5b
Compare
@tomplus could you take a look at this pull request preemptively? I'm still waiting for an official release of aiohttp containing aio-libs/aiohttp#7541 and until then, I'm not going to turn this pull request into an official one (the tests are not passing because of this). But it would be nice to get a first overview on the general approach, in particular the patch post-client generation. |
@multani Thanks. It looks good to me. If you have time you can also create a PR to openapi-generator, it helps us to remove the patch in the feature (https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/python/asyncio/rest.mustache). |
@tomplus Thanks, that was exactly the kind of feedback I was looking for :) I'll make the pull request there as well then! edit: it's there as a draft too: OpenAPITools/openapi-generator#16380 |
0eeed5b
to
1278907
Compare
1278907
to
5de47e8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
=======================================
Coverage 23.39% 23.40%
=======================================
Files 749 749
Lines 104991 105004 +13
=======================================
+ Hits 24564 24575 +11
- Misses 80427 80429 +2 ☔ View full report in Codecov by Sentry. |
The related patch for aiohttp has been released in v3.9.0: this patch also bumps the minimum version for this library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution...
This honors the
tls-server-name
parameter which can be present in akubeconfig
configuration file.The implementation is similar to the one done in kubernetes-client/python#1933
This needs a released version of aio-libs/aiohttp#7541This is implemented in aiohttp v3.9.0.Fix: #267