-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most functions could be const #56
Comments
Many methods can, but it's not yet possible to convert from other types, and without those, making other methods const doesn't seem all that useful. Creating For many of the functions that can be made const, it isn't as simple as slapping For |
Most For
|
It seems that |
|
Since 'Vec::new()' is already a const function, there is no difference in generated MIR/ASM whether 'AsciiString::new()' is marked 'const' or not. I saw issue #56 is waiting to mark this function as 'const', and so this PR simply marks 'AsciiString::new()' as a const fn. Thanks for reviewing this PR :)
See title. I'm not an expert on what subset of const functions are stabilized yet, but I think a lot could already be
const fn
(thinkAsciiChar::as_byte
).The text was updated successfully, but these errors were encountered: