Refactor: Dynamic tag parser #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusborne
added
bug
|
@tomusborne I pushed my commit with the changes that worked. Still haven't quite gotten the pipe handling down yet though. |
|
@iansvo Let's put those changes in a new PR based on this one so we can test further without it holding up this PR. |
iansvo
force-pushed
the
refactor/dynamic-tag-parser
branch
from
2d4c504 to
efc7962
Compare
|
@tomusborne I reset the branch to the previous version and I opened a new PR #1543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1539
Our current dynamic tag parser has a flaw that prevents multiple tags from being parsed if one of them has no options, and the other one does.
This PR aims to simplify the parser so that it treats all dynamic tags the same, regardless of whether they have options or not.