Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Tags - Remove get_queried_object_id #1570

Closed

Conversation

iansvo
Copy link
Collaborator

@iansvo iansvo commented Dec 5, 2024

Reference: https://generate.support/topic/new-dynamic-tags-wont-render-on-front-end/#post-144381

This was breaking the dynamic tags ID lookup when the dynamic tag was used in “content template” such as a loop item for an archive page. 

Removing this has had no adverse effects, archive_title still works as expected, etc.

@iansvo iansvo self-assigned this Dec 5, 2024
@iansvo iansvo requested a review from tomusborne December 5, 2024 22:04
@tomusborne
Copy link
Owner

@tomusborne
Copy link
Owner

@iansvo What about things like the "Current" term for term meta?

@tomusborne
Copy link
Owner

@iansvo I think this is the move: #1576

We actually already look for the term type when getting things like term meta: https://github.com/tomusborne/generateblocks-pro/blob/release/1.8.0/includes/extend/dynamic-tags/class-register.php#L245

@tomusborne tomusborne closed this Dec 7, 2024
@tomusborne tomusborne deleted the bug/query-content-template-dynamic-tags branch December 7, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants