Bug - Loop Item tag not always visible in Loop Item block

[iansvo]

Closes https://github.com/tomusborne/generateblocks-pro/issues/785

[tomusborne]

This seems to break the blocks inside of the Looper.

broken-query.mp4

I'm also not 100% sure why the changes in the PR would fix the mentioned issue? Any context there?

[iansvo]

This issue prevents the Loop Item tag from being hidden because the loop doesn't see anything. I had previously set up some fallback context, but the hasResolvedData check when rendering caused it to not get used.

So by doing this, loopItemsContext always wraps the output, no matter if the query is empty or not. This ensures there's always a loopItem, loopIndex, and previewId for loop items, even if the query is empty.

I made a tweak just now to make sure the currentPostId was being used here, just in case. With this change, I'm seeing everything work as expected. Can you have another look and confirm?

[tomusborne]

I'm still having issues selecting blocks with this PR.

To replicate:

1. Add Query
2. Start blank
3. Select Loop item and add empty text
4. Select something else and try to select text again

[iansvo]

@tomusborne I made a small tweak and it looks like we're in business. It appears there was a dep missing and I moved this other variable out of the memo for better stability. In my testing I'm no longer seeing this issue as you mentioned after this change.

[tomusborne]

I'm still seeing weirdness here.

loop-weirdness.mp4

At this point I'm thinking maybe we should just always show the Loop Item/Index options and ditch the conditional visibility until another date.