Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#238: Support Infura project secret. #239

Merged
merged 3 commits into from
Jul 29, 2019
Merged

#238: Support Infura project secret. #239

merged 3 commits into from
Jul 29, 2019

Conversation

steveswing
Copy link
Contributor

Changed to support Infura project secret that omits a username.

tomusdrw
tomusdrw approved these changes Jul 29, 2019
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Just one tiny improvement proposed.

src/transports/http.rs Outdated Show resolved Hide resolved
@tomusdrw tomusdrw merged commit f417273 into tomusdrw:master Jul 29, 2019
@steveswing steveswing deleted the #238 branch July 31, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steveswing @tomusdrw