Improve error for byte deserialization #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We improve the error the error message for deserialization failures of `Byte`. We drop the length check because `rustc_hex` returns an error when the length is not even.
tomusdrw
approved these changes
Sep 8, 2019
| } else { | ||
| Err(Error::custom("invalid format")) | ||
| Err(Error::invalid_value(Unexpected::Str(value), &"0x prefix")) |
There was a problem hiding this comment.
In principle this will also be displayed if the length is less than 2, but it's strictly better than what we have currently.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We improve the error the error message for deserialization failures of
Byte.We drop the length check because
rustc_hexreturns an error when the length is not even.