Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated a few trace-related types to make their fields public #260

Merged
merged 4 commits into from
Sep 23, 2019
Merged

Updated a few trace-related types to make their fields public #260

merged 4 commits into from
Sep 23, 2019

Conversation

r3v2d0g
Copy link
Contributor

@r3v2d0g r3v2d0g commented Sep 21, 2019 •
edited
Loading

Hey 👋!

I updated a few trace-related types to make their fields public 😃.

@r3v2d0g
Updated StateDiff to make its inner map public
47a896b 
Signed-off-by: Matthieu Le brazidec <matthieu@lebrazidec.email>
@r3v2d0g
Updated ChangedType and TransactionTrace to make their fields public
9e05db3 
Signed-off-by: Matthieu Le brazidec <matthieu@lebrazidec.email>
@r3v2d0g
Copy link
Contributor Author

r3v2d0g commented Sep 21, 2019

Also, I was wondering whether we should make the fields of Filter and TraceFilter public.

@r3v2d0g
Updated Trace to make its action_type field public
81bdae6 
Signed-off-by: Matthieu Le brazidec <matthieu@lebrazidec.email>
@r3v2d0g r3v2d0g changed the title Updated StateDiff to make its inner map public Update a few trace-related types to make their fields public Sep 21, 2019
@r3v2d0g r3v2d0g changed the title Update a few trace-related types to make their fields public Updated a few trace-related types to make their fields public Sep 21, 2019
tomusdrw
tomusdrw approved these changes Sep 23, 2019
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomusdrw tomusdrw merged commit af83967 into tomusdrw:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3v2d0g @tomusdrw