Removed Res::FailedCallOrCreate and added missing fields to TransactionTrace #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋!
Parity encodes traces results in one of two fields:
CallResult
,CreateResult
or be equal tonull
(Res::None
)TraceError
(https://github.com/paritytech/parity-ethereum/blob/master/ethcore/trace/src/types/error.rs#L25) and which Parity considers as either aFailedCall
orFailedCreate
Currently,
Res
would only be able to decode aCallResult
,CreateResult
orNone
because it would only look into the "result" field. Thus,FailedCallOrCreate
is unnecessary butTrace
andTransactionTrace
need anerror
field (TransactionTrace
didn't have one).I also added an
action_type
field toTransactionTrace
.