Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented From<H256> for TransactionId #273

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Implemented From<H256> for TransactionId #273

merged 2 commits into from
Oct 16, 2019

Conversation

r3v2d0g
Copy link
Contributor

@r3v2d0g r3v2d0g commented Oct 15, 2019

Hey 👋!

I just implemented From<H256> for TransactionId which returns TransactionId::Hash(_) 😃.

@r3v2d0g
Implemented From<H256> for TransactionId
eb45b6d 
Signed-off-by: Matthieu Le brazidec <matthieu@lebrazidec.email>
tomusdrw
tomusdrw approved these changes Oct 16, 2019
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks good. Just one fix to make the rustfmt happy.

src/types/transaction_id.rs Outdated Show resolved Hide resolved
@r3v2d0g @tomusdrw
Fixed formatting
bb79ca1 
Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
@tomusdrw tomusdrw merged commit ff1a273 into tomusdrw:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3v2d0g @tomusdrw