Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add transaction signing with in accounts sub-namespace. #315

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Revert "Add transaction signing with in accounts sub-namespace. #315

merged 1 commit into from
Jan 28, 2020

Conversation

tomusdrw
Copy link
Owner

@tomusdrw tomusdrw commented Jan 27, 2020 •
edited
Loading

Reverts #279

This reverts commit 5e8e0a4.

Due to incompatible license of downstream libs. Can be potentially revisited in the future if the license of ethsign and ethereum-transaction was made more permissive.

@tomusdrw tomusdrw changed the title Revert "Add transaction signing with in accounts sub-namespace. (#2… Revert "Add transaction signing with in accounts sub-namespace. Jan 27, 2020
@tomusdrw tomusdrw merged commit 9928849 into master Jan 28, 2020
@tomusdrw tomusdrw deleted the td-revert-accounts branch January 28, 2020 09:22
tomusdrw pushed a commit that referenced this pull request Feb 11, 2020
@nlordell
Reimplement transaction signing with license compatible crate (#325)
74b14ad 
* Revert "Revert "Add transaction signing with in `accounts` sub-namespace. (#279)" (#315)"

This reverts commit 9928849.

* implemented signing and recovery with secp256k1 crate

* attempt to protect key from being leaked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomusdrw