Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement parity namespace #318

Merged
merged 5 commits into from
Jan 29, 2020
Merged

Implement parity namespace #318

merged 5 commits into from
Jan 29, 2020

Conversation

gulitsky
Copy link
Contributor

Do it mostly for very handy parity_call method that allowing to run sequential eth_calls in one request. Also i'm tried to implement a batch version of web3::contract::Contract::query method using parity_call, but have not yet figured out how.

tomusdrw
tomusdrw approved these changes Jan 29, 2020
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please just add some docs to the method itself.

src/api/parity.rs Outdated Show resolved Hide resolved
@tomusdrw
Copy link
Owner

Can you please run cargo fmt on the code?
image

@tomusdrw tomusdrw merged commit 07b960a into tomusdrw:master Jan 29, 2020
@tomusdrw
Copy link
Owner

Perfect thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gulitsky @tomusdrw