Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #342
More details in issue, but basically mirroring the
Block
struct from https://github.com/openethereum/openethereum/blob/master/rpc/src/v1/types/block.rs#L48This required making
logs_bloom
andtotal_difficulty
optionalTest Plan
I ran the unit tests (but the example block contains only non-null fields). Will also make sure that the example given in the issue now fetches pending blocks successfully.