Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logs_bloom optional #343

Merged
merged 3 commits into from
May 12, 2020
Merged

Make logs_bloom optional #343

merged 3 commits into from
May 12, 2020

Conversation

fleupold
Copy link
Contributor

Closes #342

More details in issue, but basically mirroring the Block struct from https://github.com/openethereum/openethereum/blob/master/rpc/src/v1/types/block.rs#L48

This required making logs_bloom and total_difficulty optional

Test Plan

I ran the unit tests (but the example block contains only non-null fields). Will also make sure that the example given in the issue now fetches pending blocks successfully.

@tomusdrw
Copy link
Owner

Would be cool to add a test that contains null (an example pending block)
and fix the CI errors - most likely a cargo fmt run is needed.

@tomusdrw
Copy link
Owner

Thanks a lot!

@tomusdrw tomusdrw merged commit 6f24d97 into tomusdrw:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eth::block() not working for BlockNumber::Pending
2 participants