Support eth_call by block hash #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoyvens
force-pushed
the
eth-call-by-hash
branch
2 times, most recently
from
809118a
to
da94b6c
Compare
leoyvens
force-pushed
the
eth-call-by-hash
branch
from
da94b6c
to
6d9d8fb
Compare
tomusdrw
approved these changes
May 14, 2020
| @@ -158,7 +158,11 @@ impl Serialize for BlockId { | |||
| S: Serializer, | |||
| { | |||
| match *self { | |||
| BlockId::Hash(ref x) => serializer.serialize_str(&format!("0x{}", x)), | |||
| BlockId::Hash(ref x) => { | |||
There was a problem hiding this comment.
Initially I thought this is going to break some of the existing APIs using BlockId, but it's not the case. In fact it seems that the fact that Serialize is implemented for BlockId is not used anywhere in the rust-web3 codebase internally, so it's okay to change it.
|
Thanks a lot! |
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #285 by having the block parameter to
callbe aBlockIdinstead of aBlockNumber(breaking change), and serializing theBlockIdin the manner expected by EIP 1898.