Make CallRequest's to
field optional
#348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Ethereum Wiki page on JSON-RPC, the
eth_call
andeth_estimateGas
calls use the same parameters, with the exception that all the fields foreth_estimateGas
are optional.Currently,
CallRequest
'sto
field was not optional. This PR changes that, making it suitable for use witheth_estimateGas
.I have a question about the RPC test I added with a
None
value forto
. I didn't know whateth_estimateGas
would return in that case, so I left the response from the test I copied. It passes, but I'm not sure it should considering thatValue::String("0x123".into()) => 0x123
was in reference to theto
address. What should this test check instead?