Contract calldata api #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
requested changes
May 27, 2020
There was a problem hiding this comment.
Hey! Thanks for the PR, but I don't feel this suits the interface of web3. This can easily be done using ethabi directly.
I'm willing to accept a PR that simply exposes the ethabi::Contract reference, like so:
/// Get the underlying contract ABI.
pub fn abi(&self) -> ðabi::Contract {
&self.abi
}With this you can get the call data via:
let bytes = contract.abi().function(func)?.encode_input(¶ms.into_tokens());
src/contract/mod.rs
Outdated
| nonce, | ||
| condition, | ||
| } = options; | ||
| .unwrap() |
There was a problem hiding this comment.
The error is there for a reason, simply unwraping will cause panics in case the function is not found.
There was a problem hiding this comment.
Thanks for pointing me towards #17 .. ethabi_derive looks really nice 👌
Sorry about the unwrap() .. should have been an issue not a pull request 🙄
There was a problem hiding this comment.
No worries @kyledewy, thanks a lot for the contribution!
tomusdrw
approved these changes
May 27, 2020
|
Awesome, cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey I wanted to use the library to construct calldata for contract functions, but I wasn't able to find anything.
I just did a quick change to see if I could expose the api for this, but I'm happy to clean it up if it makes sense.