-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update implementation of Tokenizable for Vec<u8> #377
Conversation
src/contract/tokens.rs
Outdated
Token::FixedBytes(data) => Ok(data), | ||
other => Err(Error::InvalidOutputType(format!("Expected `bytes`, got {:?}", other))), | ||
Token::Bytes(data) | Token::FixedBytes(data) => Ok(data), | ||
Token::Array(tokens) | Token::FixedArray(tokens) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with this is that you will decode Vec<u8>
from Token::Array
, but encoding (into_tokens
) will always return Token::Bytes
which is quite misleading.
The split is done on purpose currently (also a bit due to Rust limitations). I think the best way forward would be to introduce a type that looks like this:
pub struct BytesArray(pub Vec<u8>);
impl Tokenizable for BytesArray {
fn from_token(token: Token) -> Result<Self, Error> {
match token {
Token::FixedArray(tokens) | Token::Array(tokens) => {
Ok(Self(tokens.into_iter().map(Tokenizable::from_token).collect()?))
}
other => Err(Error::InvalidOutputType(format!("Expected `Array`, got {:?}", other))),
}
}
fn into_token(self) -> Token {
Token::Array(self.into_iter().map(Tokenizable::into_token).collect())
}
}
Unless Token::Bytes
and Token::Array
have the same ethabi encoding and there is no confusion here (I really don't remember).
Also please add tests.
0396a44
to
c8ce00b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! tiny doc improvement
Thank you! |
The contract call could return
uint8[]
instead ofbytes
, butVec<u8>
implementation just supportsbytes
.