Convert transaction signing to async
#387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converting the manual Future implementation to async makes the code simpler and no longer require Unpin.
tomusdrw
approved these changes
Oct 16, 2020
| pub fn sign_transaction<K: signing::Key>(&self, tx: TransactionParameters, key: K) -> SignTransactionFuture<T, K> { | ||
| SignTransactionFuture::new(self, tx, key) | ||
| /// | ||
| /// Transaction signing can perform RPC requests in order to fill missing |
|
Are you sure you want to bump version immediately? To be clear, this code does not yet have outside observable effect. It removes the Unpin requirement of this piece of code but we'll need to make similar changes in several places before we can remove the Unpin bound on Transport. |
Bumping the version, just so that I don't forget to do it later on. Different return types is a breaking change already, so I'd prefer to indicate that the git version is different than what's on crates.io. Totally fine with merging more changes before the actual release. |
|
Makes sense 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting the manual Future implementation to async makes the code
simpler and no longer require Unpin.
part of #361