Remove more instances of Unpin #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
reviewed
Nov 6, 2020
| @@ -229,10 +229,13 @@ impl<T> Response<T> { | |||
| } | |||
| } | |||
|
|
|||
| // We can do this because `hyper::client::ResponseFuture: Unpin`. | |||
| impl<T> Unpin for Response<T> {} | |||
There was a problem hiding this comment.
If we trust the compiler then this must be okay because it does compile and there is no unsafe. I think this is because we never construct a Pin<T> so whether T is Unpin doesn't matter. Although I am not sure why the compiler doesn't automatically implement Unpin in this case.
tomusdrw
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not required for
Transportbut I thought I'd clean up all of the remaining Unpin instances (except forws.rs).