Update block.rs for pending block #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
requested changes
Nov 13, 2020
src/types/block.rs
Outdated
| @@ -14,7 +14,7 @@ pub struct BlockHeader { | |||
| pub uncles_hash: H256, | |||
| /// Miner/author's address. | |||
| #[serde(rename = "miner")] | |||
| pub author: H160, | |||
| pub author: Option<H160>, | |||
There was a problem hiding this comment.
It's really weird that author/miner is not set, I can't find any evidence of this change. Since this is an edge case and I can imagine anyone really wanting to handle the None case, let's please use default value instead of Option.
Suggested change
| pub author: Option<H160>, | |
| #[serde(default)] | |
| pub author: H160, |
src/types/block.rs
Outdated
| @@ -63,7 +63,7 @@ pub struct Block<TX> { | |||
| pub uncles_hash: H256, | |||
| /// Miner/author's address. | |||
| #[serde(rename = "miner")] | |||
| pub author: H160, | |||
| pub author: Option<H160>, | |||
There was a problem hiding this comment.
Suggested change
| pub author: Option<H160>, | |
| #[serde(default)] | |
| pub author: H160, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.