feat: support parity_pendingTransactions #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohoff
force-pushed
the
feat/parity-pending-txs
branch
from
4594e72
to
f41991a
Compare
tomusdrw
reviewed
Jan 19, 2021
|
|
||
| /// Filter for pending transactions (only openethereum/Parity) | ||
| #[derive(Clone, Default, Serialize)] | ||
| pub struct ParityPendingTransactionFilter { |
There was a problem hiding this comment.
Could you please add ::builder() function to make it easy to create builder struct without importing the type?
impl ParityPendingTransactionFilter {
pub fn builder() -> ParityPendingTransactionFilterBuilder {
Default::default()
}
}
|
@tomusdrw Addressed all feedback and learnt a few things, thank you! I also updated the test to use the example transaction from the parity docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
parity_pendingTransactions. Implements #440Applying a pending transaction filter is blocked by openethereum/openethereum#159. However, omitting a filter gives a full list of pending transactions as expected. This has been tested with a synced openethereum node.
Would love to get some feedback!