Redo http transport #497
Merged
Redo http transport #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e00E
commented
Jun 4, 2021
tomusdrw
approved these changes
Jun 7, 2021
The existing implementation has accumulated a lot of crust from initial async support and use of hyper. Now that is using reqwest we can do many things simpler. Removed things that were needed for hyper but are handled already by reqwest: - setting the proxy - setting the auth header - setting the content type header - setting content length header Other changes: - Move from struct with Future impl to BoxFuture. We were already using BoxFuture internally anyawy. - Log request and response as debug strings. This makes sure no control characters like newlines end up in the output. - Use from_utf8_lossy for the response log so that we can still partially log non utf8 responses. - Fix not handling batch responses according to the jsonrpc specification which does not guarantee the ordering of the list. - Add more context to error logs. - Allow giving a custom client to the transport. This is useful for example to set a timeout.
|
Looks like you can't set a user agent on wasm, which makes sense as the browser probably uses its own. Let's see if this fixes the build. |
tomusdrw
approved these changes
Jun 7, 2021
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation has accumulated a lot of crust from initial
async support and use of hyper. Now that is using reqwest we can do many
things simpler.
Removed things that were needed for hyper but are handled already by
reqwest:
Other changes:
BoxFuture internally anyawy.
characters like newlines end up in the output.
partially log non utf8 responses.
specification which does not guarantee the ordering of the list.