Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-1559 Support #533

Merged
merged 10 commits into from
Aug 19, 2021
Merged

EIP-1559 Support #533

merged 10 commits into from
Aug 19, 2021

Conversation

mdben1247
Copy link
Contributor

No description provided.

tomusdrw
tomusdrw reviewed Aug 11, 2021
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Could you please address the build issues?

tomusdrw
tomusdrw reviewed Aug 11, 2021
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Could you please address the build issues?

@mdben1247
Copy link
Contributor Author

I see base_fee_per_gas field has been added after I forked, so there are now two instances of this field in this merge. Any hints how to resolve that?

@mdben1247
Copy link
Contributor Author

So, this evolved a bit. There is added support for signing EIP-1559 transactions directly from rust-web3 and field gas_price in Transaction is now optional.

@mdben1247 mdben1247 changed the title Added EIP-1559 fields EIP-1559 Support Aug 18, 2021
tomusdrw
tomusdrw reviewed Aug 18, 2021
View reviewed changes
src/api/accounts.rs Outdated Show resolved Hide resolved
src/api/accounts.rs Outdated Show resolved Hide resolved
src/signing.rs Outdated Show resolved Hide resolved
tomusdrw
tomusdrw approved these changes Aug 19, 2021
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@tomusdrw tomusdrw merged commit 2e2d1df into tomusdrw:master Aug 19, 2021
@morelazers morelazers mentioned this pull request Nov 5, 2021
Closed
@the-Jamz the-Jamz mentioned this pull request Feb 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdben1247 @tomusdrw