Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize secp256k1 context only once #535

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Initialize secp256k1 context only once #535

merged 1 commit into from
Aug 14, 2021

Conversation

tomusdrw
Copy link
Owner

As suggested in #534

@tomusdrw tomusdrw enabled auto-merge (squash) August 14, 2021 20:26
@tomusdrw tomusdrw merged commit f654a9d into master Aug 14, 2021
@tomusdrw tomusdrw deleted the td-recover branch August 14, 2021 20:29
recmo
recmo reviewed Aug 16, 2021
View reviewed changes
Copy link

@recmo recmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the Secp256k1 context is only intialized once for verifying. For signing (and pubkey derivation) it still intializes contexts each time:

https://github.com/tomusdrw/rust-web3/pull/535/files#diff-e30da8c800b745948f33e34e23570b0a94f7a6f90a0b26433e851dc99f27267cR100

https://github.com/tomusdrw/rust-web3/pull/535/files#diff-e30da8c800b745948f33e34e23570b0a94f7a6f90a0b26433e851dc99f27267cLR153

@tomusdrw tomusdrw mentioned this pull request Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@recmo recmo recmo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomusdrw @recmo