Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_feeHistory implementation #558

Merged
merged 8 commits into from
Oct 21, 2021
Merged

eth_feeHistory implementation #558

merged 8 commits into from
Oct 21, 2021

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented Oct 19, 2021

Added the eth_feeHistory function that was introduced as part of the London hard fork.

tomusdrw
tomusdrw reviewed Oct 20, 2021
View reviewed changes
Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good, but I'd appreciate a little bit more love for docs and tests :)

src/api/eth.rs Outdated Show resolved Hide resolved
src/api/eth.rs Outdated Show resolved Hide resolved
src/api/eth.rs Outdated Show resolved Hide resolved
src/types/block.rs Show resolved Hide resolved
src/types/fee_history.rs Outdated Show resolved Hide resolved
src/types/fee_history.rs Outdated Show resolved Hide resolved
src/types/fee_history.rs Outdated Show resolved Hide resolved
src/types/fee_history.rs Outdated Show resolved Hide resolved
src/types/fee_history.rs Outdated Show resolved Hide resolved
src/types/fee_history.rs Show resolved Hide resolved
sunce86 and others added 7 commits October 21, 2021 10:48
@sunce86 @tomusdrw
Update src/api/eth.rs
24ca183 
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
@sunce86 @tomusdrw
Update src/api/eth.rs
09ec454 
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
@sunce86 @tomusdrw
Update src/types/fee_history.rs
41b3eee 
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
@sunce86 @tomusdrw
Update src/types/fee_history.rs
5d09e1f 
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
@sunce86 @tomusdrw
Apply suggestions from code review
2e9432a 
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
@sunce86
added unit tests
3c2ec3c
@sunce86
changed example because cant use assert_approx_eq for floats here
541b41c
@tomusdrw tomusdrw enabled auto-merge (squash) October 21, 2021 22:52
@tomusdrw tomusdrw merged commit a425fa7 into tomusdrw:master Oct 21, 2021
@sunce86 sunce86 deleted the sunce86/implement-fee-history branch October 24, 2021 08:24
TraceBundy pushed a commit to TraceBundy/rust-web3 that referenced this pull request Nov 9, 2021
@sunce86 @tomusdrw @TraceBundy
eth_feeHistory implementation (tomusdrw#558)
01e277e 
* eth_feeHistory implementation

* Update src/api/eth.rs

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* Update src/api/eth.rs

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* Update src/types/fee_history.rs

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* Update src/types/fee_history.rs

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* added unit tests

* changed example because cant use assert_approx_eq for floats here

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunce86 @tomusdrw