Ethereum Name Service

[SionoiS]

Please advise on error handling and test cases.

[tomusdrw]

Thank you so much for the contribution.

I don't know details of ENS, but I trust it's implemented correctly. Regarding the tests it should be possible to verify payload sent to eth_call.

It would be good to polish docs as well.

I think the error handling is okay, unless there are cases where specific reversion reasons from EVM are useful for the end users.

[SionoiS]

I changed the organisation and added missing functions even those without info and added links to contracts.

Let me know what you think!

Tests, example and docs will have to wait a bit. I received a grant but work start next year.

[tomusdrw]

Thank you so much for all the effort and apologies for the delay. Would you mind to fix all the remaining documentation grumbles?

[SionoiS]

A per ens/mod.rs the only type accessible is ENS.

@tomusdrw most of the documentation your asking for is not user facing. Are you sure? More docs is better I get it.

[tomusdrw]

@tomusdrw most of the documentation your asking for is not user facing. Are you sure? More docs is better I get it.

Correct, internal documentation is useful as well and I think we should put a bit of attention and effort there. Also from my experience it happens rather frequently that things that initially were not public end up being used at some point, so we can already be prepared for this :)