Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not require effectiveGasPrice in TransactionReceipt, #570

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Do not require effectiveGasPrice in TransactionReceipt, #570

merged 2 commits into from
Nov 17, 2021

Conversation

marmistrz
Copy link
Contributor

for compatibility with Ganache v6.12.2

@marmistrz
Copy link
Contributor Author

The test should_fail_to_deserialize_decimals passes for me locally and the test seems not connected to the PR. I rebased in hope it fixes the CI.

@hubertbudzynski-stc
Copy link

This test does not pass for me on the current master as well. Tried rust 1.55.0, 1.56.0 and 1.56.1

@tomusdrw
Copy link
Owner

Apologies, fixed in #571

@marmistrz
Copy link
Contributor Author

Thanks!

@tomusdrw tomusdrw merged commit 8cbac95 into tomusdrw:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marmistrz @hubertbudzynski-stc @tomusdrw @marmistrz-stc