move Accounts::hash_message and make it static #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
reviewed
Feb 2, 2022
|
Thanks a lot for the contribution and sorry for the delay with reviewing! |
blackghost1987
force-pushed
the
move_hash_message
branch
from
a2a71d0
to
bf2e1b3
Compare
|
I think this is ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account::hash_message is actually a static function, there's no point in having it under Accounts. It would be more convenient to be able to access this function without creating an Account and a Transport. I've kept the Accounts::hash_message function for backward compatibility reasons though.
I've moved hash_message to api/mod.rs as I haven't found a better place for it, but I'm open to suggestions. Is there already place for static functions like this under api somewhere?
Let me know if I need to do anything else, because this is my first contribution for this project!