Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting basic auth credentials in websocket url #590

Merged
merged 6 commits into from
Feb 4, 2022
Merged

Allow setting basic auth credentials in websocket url #590

merged 6 commits into from
Feb 4, 2022

Conversation

717a56e1
Copy link
Contributor

These could be set before, but would be ignored by soketto. Now they're propagated to the backend.

Copy link
Owner

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks a lot!

src/transports/ws.rs Outdated Show resolved Hide resolved
src/transports/ws.rs Outdated Show resolved Hide resolved
src/transports/ws.rs Outdated Show resolved Hide resolved
717a56e1 and others added 3 commits February 2, 2022 20:24
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
@tomusdrw
Copy link
Owner

tomusdrw commented Feb 4, 2022

Fixes #567

@tomusdrw tomusdrw enabled auto-merge (squash) February 4, 2022 16:51
@tomusdrw tomusdrw merged commit 4f985c5 into tomusdrw:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants