Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings #597

Merged
merged 19 commits into from
Feb 5, 2022
Merged

Fix clippy warnings #597

merged 19 commits into from
Feb 5, 2022

Conversation

niclaslind
Copy link
Contributor

Made changes that were suggested by Clippy

@niclaslind
removed unneeded unit return type
47f52a8
@niclaslind
borrowed a reference that immediately got dereferenced by the compiler
f249c58
@niclaslind
deleted unnecessary closure for substituting value for Option::None
883a134
@niclaslind
replace match block with matches! macro instead
6fc65df
@niclaslind
use unwrap_or_else instead to avoid potentially side effects
e3ec209
@niclaslind
no need to use question mark here becuase execution of the body will …
c32ad37 
…end up there anyway
@niclaslind
borrowed a reference that immediately got dereferenced by the compiler
c531978
@niclaslind
borrowed a reference that immediately got dereferenced by the compiler
0339bb4
@niclaslind
when replacing a value of type T with T::default() std::mem::take…
357e64a 
… is a better option
@niclaslind
use the map function instead of implenting it manually
a74acb4
@niclaslind
use .is_empty() instead of checking the length is bigger then 0
e7ca6b4
@niclaslind
use .is_some() and is_none() instead of creating an unused variable
548b633
@niclaslind
implementing the From Trait and we will get the Into for free
905f2f8
@niclaslind
add Default
5cb6201
@niclaslind
declare it as u64 instead of cast it to u64
8b979f3
@niclaslind
deleted unnecessary clone
25a7c17
@niclaslind
use assert! for booleans comparisons
7b9339d
@niclaslind
Merge branch 'master' into td-clippy-warnings
b0a9e14
@tomusdrw tomusdrw enabled auto-merge (squash) February 5, 2022 19:48
@tomusdrw
Copy link
Owner

tomusdrw commented Feb 5, 2022

Thanks a lot!

@tomusdrw tomusdrw merged commit 190c21d into tomusdrw:master Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niclaslind @tomusdrw