Re-export secp256k1::SecretKey. #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`secp256k1::SecretKey` is required in order to use the offline signing functionality but it's not re-exported.
This is a simple PR that re-exports the `SecretKey` which allows the following:
```rust
let s = web3::SecretKey::from_str("XYZ");
web3.accounts().sign_transaction(my_tx, &prvk).await?;
```
without having to import `secp256k1` as an explicit dependency alongside `web3`.
|
While I think the original intent was to only expose |
tomusdrw
approved these changes
Jun 2, 2023
auto-merge was automatically disabled
June 5, 2023 11:03
Head branch was pushed to by a user without write access
|
Thanks for this - I fixed the formatting issue that was blocking the merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secp256k1::SecretKeyis required in order to use the offline signing functionality but at present it's not re-exported. This means anyone who want to use the signing functionality has to add an explicit dependency onsecp256k1, and has to keep it in-sync with the version inweb3.This PR changes the re-export of the
secp256k1::SecretKeyfrompub(crate)topubso that is can be accessed through theweb3::signingmodule, removing the requirement for an explicit dependency on secp256k1.