Fix Bytes deserialization for unicode values #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
reviewed
Jun 14, 2023
popzxc
force-pushed
the
fix-bytes-deserialization
branch
from
f27ba1d
to
d05d283
Compare
tomusdrw
approved these changes
Jun 14, 2023
|
@tomusdrw I kind of need this fix for my project, could you please release a new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
Bytesdeserialization logic can panic if supplied non-ASCII values: it usesstr::lenandSliceIndex<str>, both of which are byte-based (not char-based).The deserializer code can panic when
[0..2]range is not on the char boundary.This PR fixed it by checking whether the string is ASCII first.