Use ethereum-types library for uints and hashes

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "web3"
-version = "0.1.0"
+version = "0.2.0"
 description = "Ethereum JSON-RPC client."
 homepage = "https://github.com/tomusdrw/rust-web3"
 repository = "https://github.com/tomusdrw/rust-web3"
@@ -11,17 +11,18 @@ authors = ["Tomasz Drwięga <tomasz@ethcore.io>"]
 
 [dependencies]
 arrayvec = "0.3"
+error-chain = "0.11.0"
 ethabi = "4.0"
+ethereum-types = "0.2.3"
 futures = "0.1"
-jsonrpc-core = "7.0"
+jsonrpc-core = "7.1"
 log = "0.3"
 parking_lot = "0.4"
 rustc-serialize = "0.3"
 serde = "1.0"
-serde_json = "1.0"
 serde_derive = "1.0"
+serde_json = "1.0"
 tokio-timer = "0.1"
-error-chain = "0.11.0-rc.2"
 # Optional deps
 hyper = { version = "0.11", optional = true }
 tokio-core = { version = "0.1", optional = true }

examples/contract.rs

@@ -16,7 +16,7 @@ fn main() {
   // Deploying a contract
   let contract = Contract::deploy(web3.eth(), include_bytes!("../src/contract/res/token.json")).unwrap()
       .confirmations(4)
-      .options(Options::with(|mut opt| opt.gas = Some(5_000_000.into())))
+      .options(Options::with(|opt| opt.value = Some(5.into())))
       .execute(bytecode, (
           U256::from(1_000_000),
           "My Token".to_owned(),

src/contract/deploy.rs

@@ -144,7 +144,7 @@ mod tests {
 
       // when
       builder
-        .options(Options::with(|mut opt| opt.value = Some(5.into())))
+        .options(Options::with(|opt| opt.value = Some(5.into())))
         .confirmations(1)
         .execute(vec![1, 2, 3, 4], (U256::from(1_000_000), "My Token".to_owned(), 3u64, "MT".to_owned()), 5.into())
         .unwrap()

src/contract/mod.rs

@@ -196,7 +196,7 @@ mod tests {
       let token = contract(&transport);
 
       // when
-      token.query("name", (), Address::from(5), Options::with(|mut options| {
+      token.query("name", (), Address::from(5), Options::with(|options| {
         options.gas_price = Some(10_000_000.into());
       }), BlockNumber::Latest).wait().unwrap()
     };
@@ -214,7 +214,7 @@ mod tests {
   fn should_call_a_contract_function() {
     // given
     let mut transport = TestTransport::default();
-    transport.set_response(rpc::Value::String(format!("{:?}", H256::from(5))));
+    transport.set_response(rpc::Value::String(format!("0x{:?}", H256::from(5))));
 
     let result = {
       let token = contract(&transport);
@@ -235,7 +235,7 @@ mod tests {
   fn should_estimate_gas_usage() {
     // given
     let mut transport = TestTransport::default();
-    transport.set_response(rpc::Value::String(format!("{:?}", U256::from(5))));
+    transport.set_response(rpc::Value::String(format!("0x{:?}", U256::from(5))));
 
     let result = {
       let token = contract(&transport);

src/contract/tokens.rs

@@ -3,7 +3,7 @@
 use arrayvec::ArrayVec;
 use ethabi::Token;
 use contract::error::{Error, ErrorKind};
-use types::{self, Address, H256, U256, U64};
+use types::{Address, H256, U256, U128};
 
 /// Output type possible to deserialize from Contract ABI
 pub trait Detokenize {
@@ -132,7 +132,7 @@ impl Tokenizable for H256 {
         for (idx, val) in s.drain(..).enumerate() {
           data[idx] = val;
         }
-        Ok(H256(data))
+        Ok(data.into())
       },
       other => Err(ErrorKind::InvalidOutputType(format!("Expected `H256`, got {:?}", other)).into()),
     }
@@ -147,13 +147,13 @@ impl Tokenizable for H256 {
 impl Tokenizable for Address {
   fn from_token(token: Token) -> Result<Self, Error> {
     match token {
-      Token::Address(data) => Ok(types::H160(data)),
+      Token::Address(data) => Ok(data.into()),
       other => Err(ErrorKind::InvalidOutputType(format!("Expected `Address`, got {:?}", other)).into()),
     }
   }
 
   fn into_token(self) -> Token {
-    Token::Address(self.0)
+    Token::Address(self.into())
   }
 }
 
@@ -168,15 +168,17 @@ macro_rules! uint_tokenizable {
       }
 
       fn into_token(self) -> Token {
-        let u = U256::from(self.0.as_ref());
-        Token::Uint(u.0)
+        let mut arr = [0; 32];
+        self.to_big_endian(&mut arr);
+        let u = U256::from(&arr);
+        Token::Uint(u.into())
       }
     }
   }
 }
 
 uint_tokenizable!(U256, "U256");
-uint_tokenizable!(U64, "U64");
+uint_tokenizable!(U128, "U128");
 
 impl Tokenizable for u64 {
   fn from_token(token: Token) -> Result<Self, Error> {
@@ -188,7 +190,7 @@ impl Tokenizable for u64 {
 
   fn into_token(self) -> Token {
     let u = U256::from(self);
-    Token::Uint(u.0)
+    Token::Uint(u.into())
   }
 }
 

src/lib.rs

@@ -4,6 +4,7 @@
 
 extern crate arrayvec;
 extern crate ethabi;
+extern crate ethereum_types;
 extern crate jsonrpc_core as rpc;
 extern crate parking_lot;
 extern crate rustc_serialize;

src/transports/http.rs

@@ -97,6 +97,9 @@ impl Http {
     Ok(Http {
       id: Default::default(),
       url: url.parse()?,
+      // TODO [ToDr] This may lock down the event loop
+      // if the queue is full and you send another request
+      // from the event loop.
       write_sender: Mutex::new(write_sender.wait()),
     })
   }

src/transports/ipc.rs

@@ -92,6 +92,9 @@ impl Ipc {
 
     Ok(Ipc {
       id: atomic::AtomicUsize::new(1),
+      // TODO [ToDr] This may lock down the event loop
+      // if the queue is full and you send another request
+      // from the event loop.
       write_sender: Mutex::new(write_sender.wait()),
       pending,
     })
@@ -102,7 +105,6 @@ impl Ipc {
   {
     let request = helpers::to_string(&request);
     debug!("[{}] Calling: {}", id, request);
-
     let (tx, rx) = futures::oneshot();
     self.pending.lock().insert(id, tx);
     let result = {

src/types/block.rs

@@ -1,5 +1,5 @@
 use serde::{Serialize, Serializer};
-use types::{Bytes, U64, U256, H256, H160, H2048};
+use types::{Bytes, U128, U256, H256, H160, H2048};
 
 /// The block type returned from RPC calls.
 /// This is generic over a `TX` type.
@@ -26,7 +26,7 @@ pub struct Block<TX> {
   #[serde(rename="receiptsRoot")]
   pub receipts_root: H256,
   /// Block number. None if pending.
-  pub number: Option<U64>,
+  pub number: Option<U128>,
   /// Gas Used
   #[serde(rename="gasUsed")]
   pub gas_used: U256,

src/types/mod.rs

@@ -15,10 +15,10 @@ pub use self::log::{Log, Filter, FilterBuilder};
 pub use self::transaction::{Transaction, Receipt as TransactionReceipt};
 pub use self::transaction_id::TransactionId;
 pub use self::transaction_request::{TransactionRequest, CallRequest, TransactionCondition};
-pub use self::uint::{H64, H128, H160, H256, H512, H520, H2048, U64, U256};
+pub use self::uint::{H64, H128, H160, H256, H512, H520, H2048, U128, U256};
 pub use self::work::Work;
 
 /// Address
 pub type Address = H160;
 /// Index in block
-pub type Index = U64;
+pub type Index = U128;