refactor plugin to use Messages API, add nextgen claude models #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvmncs
commented
Mar 5, 2024
Comment on lines
+95
to
+100
| if hasattr(comp, "content_block"): | ||
| response = comp.content_block.text | ||
| yield response | ||
| elif hasattr(comp, "delta"): | ||
| if hasattr(comp.delta, "text"): | ||
| yield comp.delta.text |
There was a problem hiding this comment.
this block of code is pretty fast and loose, based on their documented SSE format here. I mostly just inspected the python objects coming out of the completion stream and used this to get the raw text deltas. there's probably a more principled way to do it, happy to rewrite if that's a concern
|
sorry, didn't even realize the older PR was still open! happy to close this in favor of that if it's preferred |
|
Thanks for this @jvmncs I'll look to get this or something like it released in the next couple days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates the plugin to use the next generation of claude models. since the newer generation requires usage of anthropic's Messages API (very similar to openai's, but not exact), I migrated the plugin to use that instead of the older completions api that it was based on