Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard for mintless jettons #177

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mr-tron
Copy link

@mr-tron mr-tron commented Jul 22, 2024

No description provided.


This standard propose to use `custom_payload` to store there _claim airdrop_ command with the following scheme:
```
merkle_airdrop_claim proof:^Cell = CustomPayload;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merkle_airdrop_claim#0df602d6 proof:^Cell = CustomPayload;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again tom

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

من گیج دم چی ب چیه اصلا قاطی کردم


Method `is_minted()` for jetton wallets returns `bool` whether jetton is minted or not.

//TODO: make better naming
Copy link
Member

@EmelyanenkoK EmelyanenkoK Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed with with mr-tron instead of get_method lets move custom_payload source to metadata. This will not cause security issue (owner silently changes metadata) since Merkle root checks are done in contracts and root won't be changed.
I propose to have:
custom_payload_augmentation_endpoint with some specified scheme (like cNFT)
and custom_payload_augmentation_hashmap can be link to web2, tonstorage, ipfs ...

@EmelyanenkoK EmelyanenkoK changed the title Add standard for mitless jettons Add standard for mintless jettons Aug 3, 2024
###

In metadate stored according to [Metadata standard](https://github.com/ton-blockchain/TEPs/blob/master/text/0064-token-data-standard.md)
should be added field "mintles_merkle_dump_uri" with `string` type in json or `ContentData` type in TL-B:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mintles or mintless ?

### Useful links

1. [Reference contract implementation](https://github.com/ton-community/mintless-jetton)
2. [Custom payload API](ttps://github.com/ton-blockchain/TEPs/blob/master/text/0000-jetton-offchain-payloads.md)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https, missing "h" at the beginning

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EQCDjUcZdVCmk7myvIuZqJ7WGC1UW0845XE2rmCPKkGWiVDO

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I will use it to solve the problem of receiving jettons

In metadate stored according to [Metadata standard](https://github.com/ton-blockchain/TEPs/blob/master/text/0064-token-data-standard.md)
should be added field "mintles_merkle_dump_uri" with `string` type in json or `ContentData` type in TL-B:

`mintles_merkle_dump_uri` pointed to binary file contains BoC with merkle tree of all jettons wallets.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure that mintless (double s) should be there

= InternalMsgBody;
```

This standard propose to use `custom_payload` to store there _claim airdrop_ command with the following scheme:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to store there the


## GetMethods

Method `is_claimed()` for jetton wallets returns `bool` whether jetton is minted or not.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method return, not returns.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My problem is to transfer the verified token from tonviewer, there is no option to change or transfer to the main account

@chiliec
Copy link

chiliec commented Sep 1, 2024

Also I see that the document doesn't explicitly state what happens if the airdrop claim conditions are not met (e.g., if it's already claimed or outside the time window). It might be helpful to specify the expected behavior in these cases.

Copy link

@Ami22r Ami22r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EQCDjUcZdVCmk7myvIuZqJ7WGC1UW0845XE2rmCPKkGWiVDO

Copy link

@AkiraMatthew AkiraMatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Mintless feature should be better described for non-TON devs to understand better how it works


### Custom payload and indexation API

Described in [Jetton Offchain Payloads](https://github.com/ton-blockchain/TEPs/blob/master/text/0000-jetton-offchain-payloads.md) TEP.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL is invalid. It leads to 404


###

In metadate stored according to [Metadata standard](https://github.com/ton-blockchain/TEPs/blob/master/text/0064-token-data-standard.md)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In metadate

Perhaps you meant metadata

Copy link

@rahaftiya11 rahaftiya11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tonkeeper:mintles

Copy link

@MXzander MXzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/about-writing-and-formatting-on-github.md

### Custom payload and indexation API

Described in [Jetton Offchain Payloads](https://github.com/ton-blockchain/TEPs/blob/master/text/0000-jetton-offchain-payloads.md) TEP.

### GetMethods

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text/0000-compressed-jetton-standard.md

Copy link

@Alexforestaneev Alexforestaneev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢🙏🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.