chore: change timestamp type for ton-proof #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlikhtar
force-pushed
the
ton-proof-timestamp
branch
from
daeab19
to
7e81ff2
Compare
thekiba
reviewed
Sep 17, 2024
| @@ -109,7 +109,7 @@ type TonProofItemReply = TonProofItemReplySuccess | TonProofItemReplyError; | |||
| type TonProofItemReplySuccess = { | |||
| name: "ton_proof"; | |||
| proof: { | |||
| timestamp: string; // 64-bit unix epoch time of the signing operation (seconds) | |||
| timestamp: number; // 58-bit unix epoch time of the signing operation (seconds) | |||
There was a problem hiding this comment.
Suggested change
| timestamp: number; // 58-bit unix epoch time of the signing operation (seconds) | |
| timestamp: number; // 53-bit unix epoch time of the signing operation (seconds) |
JavaScript's number type uses IEEE 754 double-precision floating-point, which has 53 bits of precision for integers. Timestamps beyond 53 bits can lose precision.
For more details, see the ECMAScript specification on number type: https://262.ecma-international.org/15.0/#sec-ecmascript-language-types-number-type
Gulednure
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timestamp parameter within the ton_proof in the @tonconnect/sdk has historically been implemented as a number type, a practice that has been consistently adopted across all dApps and wallets with strict validation. To align the specification with this widespread implementation, I propose updating the specification to officially change the timestamp parameter type from a string to a number. After a thorough review, I can confirm that all existing wallets currently utilize the number type for this parameter, ensuring that this update would maintain compatibility with existing systems.