chore: re-add rpm builds to release workflow #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not get this stuff into it's own repository somewhere—ideally an rpm repo that others with the same distro could use? Usually upstream projects are not a good home for packaging data — the release cadence is a bad match for what usually needs to happen with packaging and the expertise usually doesn't match either. |
fabaff
reviewed
Mar 19, 2022
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| distros: ['fedora:32', 'fedora:33', 'almalinux:8'] |
There was a problem hiding this comment.
I suggest that the RPM packages for Fedora are targeting later releases. Fedora 33 is in meantime EOL for some months.
Suggested change
| distros: ['fedora:32', 'fedora:33', 'almalinux:8'] | |
| distros: ['fedora:34', 'fedora:35', 'almalinux:8'] |
|
Thanks for your contribution @pzeinlinger and sorry for taking such a long time to respond. We'd like to use external build systems to build distro packages as @alerque has suggested. So let me close this PR, but please feel encouraged to participate in #203. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197