Reset peer's endpoint when NAT traversal fails to connect to any endpoint candidates #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to connect to any endpoint candidates
strohel
reviewed
May 29, 2023
mcginty
reviewed
May 29, 2023
strohel
approved these changes
May 30, 2023
mcginty
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260
We had the logic already to reset a peer's endpoint to the server-provided endpoint when no endpoint candidates were viable, but we were missing a call to it at the end of
nat.rs.Otherwise the client was always setting the endpoint to the last endpoint in the list of NAT candidates given from the server, which triggered a diff on every fetch.
I think this was just an oversight from the original commit here:
9e55d80 (PR)