Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the logger instead of the global logging #160

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Nov 25, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 89.64% // Head: 89.61% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (0c2c94f) compared to base (993cfd4).
Patch coverage: 90.90% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   89.64%   89.61%   -0.04%     
==========================================
  Files           7        8       +1     
  Lines         647      645       -2     
==========================================
- Hits          580      578       -2     
  Misses         67       67              
Impacted Files Coverage Δ
mddatasetbuilder/__init__.py 100.00% <ø> (ø)
mddatasetbuilder/utils.py 85.50% <50.00%> (ø)
mddatasetbuilder/_logger.py 100.00% <100.00%> (ø)
mddatasetbuilder/datasetbuilder.py 89.01% <100.00%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@njzjz njzjz merged commit 8a61724 into tongzhugroup:master Nov 25, 2022
@njzjz njzjz deleted the logging branch November 25, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant