Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add pyright checker #215

Merged
merged 6 commits into from
May 25, 2024
Merged

ci: add pyright checker #215

merged 6 commits into from
May 25, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 25, 2024

No description provided.

njzjz added 2 commits May 25, 2024 18:07
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 88.05970% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 89.17%. Comparing base (0bdadc2) to head (0431214).
Report is 1 commits behind head on master.

Files Patch % Lines
mddatasetbuilder/detect.py 86.66% 6 Missing ⚠️
mddatasetbuilder/datasetbuilder.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   89.51%   89.17%   -0.34%     
==========================================
  Files           7        7              
  Lines         620      656      +36     
==========================================
+ Hits          555      585      +30     
- Misses         65       71       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

njzjz and others added 4 commits May 25, 2024 18:10
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review May 25, 2024 22:26
@njzjz njzjz merged commit e76b413 into tongzhugroup:master May 25, 2024
10 checks passed
@njzjz njzjz deleted the pyright branch May 25, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant