Enhancement/mapi errors #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadwahab
approved these changes
Apr 9, 2021
mrz1836
requested changes
Apr 9, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error is received from an MAPI server the client currently just echos a 'status code x does not match status code y' message. This doesn't give us a lot of context to work with when debugging.
This PR resolves Issue #21.
If status is OK then it just returns as before.
If there is a mismatch, we will check we have a body, if we do we attempt to map to an error type and then add the result to the error message. Otherwise we just echo the status code.
Concerns
Do all errors / non 200 status codes have the same error format?