Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/bk envelope #30

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

theflyingcodr
Copy link
Contributor

This replaces the JSONEnvelope and validation code within minercraft with the github.com/libsv/go-bk implementation.

Unit tests have also been added to check for correct mapping and validation of the wrapper struct.

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #30 (3373e15) into master (8c5383d) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 3373e15 differs from pull request most recent head 8c78345. Consider uploading reports for the commit 8c78345 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   93.61%   93.53%   -0.08%     
==========================================
  Files           8        8              
  Lines         329      325       -4     
==========================================
- Hits          308      304       -4     
  Misses         15       15              
  Partials        6        6              
Impacted Files Coverage Δ
definitions.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c5383d...8c78345. Read the comment docs.

@mrz1836 mrz1836 added the update General updates label Aug 19, 2021
Copy link
Member

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 0672fda into tonicpow:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update General updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants